fix(ls): fix path template parameter matching (#3601)

No matches are now registered for template expressions defined inside query parameters. URLs with fragments are now supported, but no matches are registered for template expressiones defined inside fragments. Refs #3517
swagger-api · Jan 2, 2024 · 7cf522d · 7cf522d
1 parent fb3f70a
commit 7cf522d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/apidom-ls/package.json b/packages/apidom-ls/package.json
@@ -116,7 +116,7 @@
     "@swagger-api/apidom-parser-adapter-yaml-1-2": "^0.89.0",
     "@swagger-api/apidom-reference": "^0.89.0",
     "@types/ramda": "~0.29.6",
-    "openapi-path-templating": "^1.3.0",
+    "openapi-path-templating": "^1.4.0",
     "ramda": "~0.29.1",
     "ramda-adjunct": "^4.1.1",
     "vscode-languageserver-protocol": "^3.17.2",

diff --git a/packages/apidom-ls/src/services/validation/linter-functions.ts b/packages/apidom-ls/src/services/validation/linter-functions.ts
@@ -1049,11 +1049,10 @@ export const standardLinterfunctions: FunctionItem[] = [
           }
         });
 
-        const allowedLocation = ['path', 'query'];
         const pathTemplateResolveParams: { [key: string]: 'placeholder' } = {};
 
         parameterElements.forEach((parameter) => {
-          if (allowedLocation.includes(toValue((parameter as ObjectElement).get('in')))) {
+          if (toValue((parameter as ObjectElement).get('in')) === 'path') {
             pathTemplateResolveParams[toValue((parameter as ObjectElement).get('name'))] =
               'placeholder';
           }