Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sideEffects package.json field to explicitly express side effects to bundlers #2566

Closed
char0n opened this issue Feb 16, 2023 · 0 comments
Closed

Use sideEffects package.json field to explicitly express side effects to bundlers #2566

char0n opened this issue Feb 16, 2023 · 0 comments
Assignees
@char0n
Labels
ApiDOM enhancement New feature or request

Comments

@char0n
Copy link
Member

char0n commented Feb 16, 2023

More info here: https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free
@char0n char0n self-assigned this Feb 16, 2023
@char0n char0n added enhancement New feature or request ApiDOM labels Feb 16, 2023
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(ast): add sideEffects field to package.json
325e3e3 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(core): add sideEffects field to package.json
bcaf53f 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(json-path): add sideEffects field to package.json
cdb95de 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(json-pointer): add sideEffects field to package.json
1ec6318 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(ns-api-design-systems): add sideEffects field to package.json
d5db7ca 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(ns-asyncapi-2): add sideEffects field to package.json
823c2a5 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(ns-json-schema-draft-4): add sideEffects field to package.json
6cb77bc 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(ns-json-schema-draft-6): add sideEffects field to package.json
82768b7 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(ns-json-schema-draft-7): add sideEffects field to package.json
63a6854 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(ns-openapi-3-0): add sideEffects field to package.json
fe4e2f1 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(ns-openapi-3-1): add sideEffects field to package.json
b9513d4 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(ns-workflows-1): add sideEffects field to package.json
defd93a 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser): add sideEffects field to package.json
4474a3e 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser-adapter-ads-json): add sideEffects field to package.json
eb1b25c 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser-adapter-ads-yaml): add sideEffects field to package.json
a994bc9 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser-asyncapi-json-2): add sideEffects field to package.json
343bb8e 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser-asyncapi-yaml-2): add sideEffects field to package.json
defe0dd 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser-adapter-json): add sideEffects field to package.json
08e5ce1 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser-openapi-json-3-0): add sideEffects field to package.json
df0358f 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser-openapi-json-3-1): add sideEffects field to package.json
9608f59 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser-openapi-yaml-3-0): add sideEffects field to package.json
7b07145 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser-openapi-yaml-3-1): add sideEffects field to package.json
80b79bb 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser-adapter-yaml-1-2): add sideEffects field to package.json
8c9a781 
Refs #2566
@char0n char0n mentioned this issue Feb 16, 2023
Merged
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(ast): add sideEffects field to package.json
c2d8104 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(core): add sideEffects field to package.json
27a6eb5 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(json-path): add sideEffects field to package.json
1e6e75b 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(json-pointer): add sideEffects field to package.json
85d32e9 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(ns-api-design-systems): add sideEffects field to package.json
24c0fe3 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(ns-asyncapi-2): add sideEffects field to package.json
6f740a3 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(ns-json-schema-draft-4): add sideEffects field to package.json
3b52219 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(ns-json-schema-draft-6): add sideEffects field to package.json
aef6a49 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(ns-json-schema-draft-7): add sideEffects field to package.json
e9706ab 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(ns-openapi-3-0): add sideEffects field to package.json
6dae3e0 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(ns-openapi-3-1): add sideEffects field to package.json
585e0b6 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(ns-workflows-1): add sideEffects field to package.json
faf7be0 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser): add sideEffects field to package.json
3370121 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser-adapter-ads-json): add sideEffects field to package.json
178a40e 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser-adapter-ads-yaml): add sideEffects field to package.json
88c760a 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser-asyncapi-json-2): add sideEffects field to package.json
c4908fc 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser-asyncapi-yaml-2): add sideEffects field to package.json
a4e0e29 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser-adapter-json): add sideEffects field to package.json
04283c4 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser-openapi-json-3-0): add sideEffects field to package.json
7045c7b 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser-openapi-json-3-1): add sideEffects field to package.json
a5c9081 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser-openapi-yaml-3-0): add sideEffects field to package.json
d341d99 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser-openapi-yaml-3-1): add sideEffects field to package.json
d8d0895 
Refs #2566
char0n added a commit that referenced this issue Feb 16, 2023
@char0n
feat(parser-adapter-yaml-1-2): add sideEffects field to package.json
8e27614 
Refs #2566
@char0n char0n closed this as completed Feb 16, 2023
char0n added a commit that referenced this issue Feb 20, 2023
@char0n
fix(build): map all side effects within the packages
e78b12e 
Side effects support was introduced in ApiDOM@0.68.0.
Unfortunately not all side effects were handled properly.

This commit remedies the ApiDOM@0.68.0 release.

Refs #2566
@char0n char0n mentioned this issue Feb 20, 2023
Merged
char0n added a commit that referenced this issue Feb 20, 2023
@char0n
fix(build): map all side effects within the packages (#2574)
ed1dcf5 
Side effects support was introduced in ApiDOM@0.68.0.
Unfortunately not all side effects were handled properly.

This commit remedies the ApiDOM@0.68.0 release.

Refs #2566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

Labels
ApiDOM enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@char0n