Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependencies on apidom-ast from apidom-ns-openapi-3-1 and apidom-ns-json-schema-draft-4 #2871

Closed
tomdegoede opened this issue Jun 19, 2023 · 6 comments
Assignees
Labels
ApiDOM JSON Schema JSON Schema related work OpenAPI 3.1

Comments

@tomdegoede
Copy link

@swagger-api/* version: 0.70.1

When bundling our application with webpack using pnpm for node_module resolution we encounter errors in @swagger-api/apidom-ns-json-schema-draft-4/es/refractor/visitors/json-schema/EnumVisitor.js and @swagger-api/apidom-ns-openapi-3-1/es/refractor/visitors/open-api-3-1/schema/EnumVisitor.js because these packages do not list @swagger-api/apidom-ast as their dependency.

pnpm creates an isolated symlink structure to make sure that npm packages only resolve their own dependencies.

@char0n char0n self-assigned this Jun 20, 2023
@char0n char0n added OpenAPI 3.1 ApiDOM JSON Schema JSON Schema related work labels Jun 20, 2023
@char0n
Copy link
Member

char0n commented Jun 20, 2023

Hi @tomdegoede,

Thanks for the report I can confirm and working on the fix.

char0n added a commit that referenced this issue Jun 20, 2023
This affected following packages:
- ns-json-schema-draft-4
- ns-openapi-3-1

Refs #2871
@char0n
Copy link
Member

char0n commented Jun 20, 2023

Addressed in #2875. There will be new release before the end of this week.

@char0n char0n closed this as completed Jun 20, 2023
char0n added a commit that referenced this issue Jun 20, 2023
This affected following packages:
- ns-json-schema-draft-4
- ns-openapi-3-1

Refs #2871
@lizthegrey
Copy link

Any news on the release @char0n?

@char0n
Copy link
Member

char0n commented Jun 27, 2023

@lizthegrey ETA during today

@char0n
Copy link
Member

char0n commented Jun 27, 2023

@lizthegrey
Copy link

Released as v0.70.3 (release)

Thanks! Fix confirmed working, yarn-pnp is happy now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ApiDOM JSON Schema JSON Schema related work OpenAPI 3.1
Projects
None yet
Development

No branches or pull requests

3 participants