Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error messages for YAML syntax errors #2889

Closed
char0n opened this issue Jun 27, 2023 · 1 comment
Closed

Better error messages for YAML syntax errors #2889

char0n opened this issue Jun 27, 2023 · 1 comment
Assignees
@char0n @damian-polewski-sb
Labels
ApiDOM YAML

Comments

@char0n
Copy link
Member

char0n commented Jun 27, 2023 •
edited

Given the following YAML fragment:

asyncapi: 2.4.0
info: 
  version: '1.0.0'
   title: Something # Badly indented

The tree-sitter will produce ERROR node with message containing the content of entire YAML fragment. In that case we can assume that the unrecoverable YAML Syntax error has happened and display the YAML Syntax error instead of the contents of YAML fragment.

Refs #194
@char0n char0n self-assigned this Jun 27, 2023
@damian-polewski-sb damian-polewski-sb self-assigned this Jul 5, 2023
@damian-polewski-sb damian-polewski-sb mentioned this issue Jul 7, 2023
Closed
17 tasks
char0n added a commit that referenced this issue Jul 11, 2023
@char0n
feat: add better YAML syntax error messages
ca4dd09 
Refs #2914
Refs #2889
@char0n char0n mentioned this issue Jul 11, 2023
Merged
char0n added a commit that referenced this issue Jul 12, 2023
@char0n
feat: add better YAML syntax error messages (#2931)
5a1d14a 
Co-authored-by: damian-polewski-sb <damian.polewski@smartbear.com>

Refs #2914
Refs #2889
@char0n
Copy link
Member Author

char0n commented Jul 17, 2023

Closed by https://github.com/swagger-api/apidom/releases/tag/v0.71.0

@char0n char0n closed this as completed Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

@damian-polewski-sb damian-polewski-sb

Labels
ApiDOM YAML
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug(apidom-parser-adapter-yaml-1-2): Change message returned for syntax errors swagger-api/apidom
2 participants
@char0n @damian-polewski-sb