Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apidom-ls: fix all linting rules using apilintElementOrClass #3763

Closed
char0n opened this issue Jan 31, 2024 · 1 comment
Closed

apidom-ls: fix all linting rules using apilintElementOrClass #3763

char0n opened this issue Jan 31, 2024 · 1 comment
Assignees
@char0n
Labels
API Design Systems ApiDOM AsyncAPI 2.x bug Something isn't working OpenApi 2.0 OpenApi 3.0 OpenAPI 3.1 Workflows Workflows specification

Comments

@char0n
Copy link
Member

char0n commented Jan 31, 2024 •
edited

The apilintElementOrClass expects array of element of classes, not string as parameter. The goal of this issues is to change all rules containing similar notations:

  linterFunction: 'apilintElementOrClass',
  linterParams: ['parametersDefinitions'],

to

  linterFunction: 'apilintElementOrClass',
  linterParams: [['parametersDefinitions']],

There are real actual bugs associated with this issue, here is an example. Only the schemais used for actual comparison and boolean is ignored.

  linterFunction: 'apilintElementOrClass',
  linterParams: ['schema', 'boolean'],

This rule must have following notation:

  linterFunction: 'apilintElementOrClass',
  linterParams: [['schema', 'boolean']],
@char0n char0n self-assigned this Jan 31, 2024
char0n added a commit that referenced this issue Jan 31, 2024
@char0n
fix(ls): fix all rules using apilintElementOrClass linting function
5ad2c85 
Refs #3763
@char0n char0n mentioned this issue Jan 31, 2024
Merged
char0n added a commit that referenced this issue Jan 31, 2024
@char0n
fix(ls): fix all rules using apilintElementOrClass linting function (#…
e3a9ee9 
…3764)

Refs #3763
@char0n
Copy link
Member Author

char0n commented Jan 31, 2024

Addressed by #3764

@char0n char0n closed this as completed Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

Labels
API Design Systems ApiDOM AsyncAPI 2.x bug Something isn't working OpenApi 2.0 OpenApi 3.0 OpenAPI 3.1 Workflows Workflows specification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@char0n