Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser-adapter-yaml-1-2: incorrect trimming #3788

Closed
char0n opened this issue Feb 5, 2024 · 1 comment
Closed

parser-adapter-yaml-1-2: incorrect trimming #3788

char0n opened this issue Feb 5, 2024 · 1 comment
Assignees
@glowcloud
Labels
ApiDOM bug Something isn't working

Comments

@char0n
Copy link
Member

char0n commented Feb 5, 2024

The parser incorrectly parses empty single quote and double quote scalars.

key: " "
key: ' '

The above string, when parsed using apidom-parser-adapter-yaml-1-2 returns ApiDOM that contains the empty string instead of one space string. I suspect issue comes from canonical-format.ts within the apidom-ast package.

Specifically formatFlowSingleQuoted and formatFlowDoubleQuoted are affected.
@char0n char0n added enhancement New feature or request ApiDOM bug Something isn't working and removed enhancement New feature or request labels Feb 5, 2024
@glowcloud glowcloud mentioned this issue Feb 5, 2024
Merged
char0n pushed a commit that referenced this issue Feb 6, 2024
@glowcloud
fix(parser-adapter-yaml-1-2): fix canonical formatting of quoted scal…
3d9ff9f 
…ars (#3792)

Refs #3788
@char0n
Copy link
Member Author

char0n commented Feb 6, 2024

Addressed in #3792

@char0n char0n closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glowcloud glowcloud

Labels
ApiDOM bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@char0n @glowcloud