Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apidom-reference: cycle in externally referenced definition #3863

Closed
4 tasks done
char0n opened this issue Feb 24, 2024 · 4 comments
Closed
4 tasks done

apidom-reference: cycle in externally referenced definition #3863

char0n opened this issue Feb 24, 2024 · 4 comments
Assignees
@char0n
Labels
ApiDOM bug Something isn't working

Comments

@char0n
Copy link
Member

char0n commented Feb 24, 2024 •
edited

Whenever we access externally referenced definition, we're refracting it, which creates entirely new ApiDOM tree. This is causing inability to track element identities and detect cycles.

TODO:

  • AsyncAPI 2.x
  • OpenAPI 2.0
  • OpenAPI 3.0.x
  • OpenAPI 3.1.0
@char0n char0n self-assigned this Feb 24, 2024
@char0n char0n added bug Something isn't working ApiDOM labels Feb 24, 2024
@char0n char0n mentioned this issue Feb 24, 2024
Closed
char0n added a commit that referenced this issue Feb 28, 2024
@char0n
fix(reference): add support for external cycles detection
23fb4f4 
Refs #3863
@char0n char0n mentioned this issue Feb 28, 2024
Merged
@char0n
Copy link
Member Author

char0n commented Feb 28, 2024

OpenAPI 3.0.x addressed in #3870

char0n added a commit that referenced this issue Feb 28, 2024
@char0n
fix(reference): add support for external cycles detection in OpenAPI …
0735471 
…3.0.x dereference strategy (#3870)

Refs #3863
char0n added a commit that referenced this issue Feb 28, 2024
@char0n
fix(reference): add support for external cycles
d674a06 
Refs #3863
@char0n char0n mentioned this issue Feb 28, 2024
Merged
char0n added a commit that referenced this issue Feb 28, 2024
@char0n
fix(reference): add support for external cycles detection in OpenAPI …
5a2141d 
…2.0 dereference strategy (#3871)

Refs #3863
char0n added a commit that referenced this issue Feb 28, 2024
@char0n
fix(reference): add support for external cycles detection
1d7f125 
Refs #3863
@char0n char0n mentioned this issue Feb 28, 2024
Merged
char0n added a commit that referenced this issue Feb 28, 2024
@char0n
fix(reference): add support for external cycles detection in AsyncAPI…
910a974 
… 2.x dereference strategy (#3872)

Refs #3863
@char0n
Copy link
Member Author

char0n commented Feb 28, 2024

OpenAPI 2.0 addressed in #3871

@char0n
Copy link
Member Author

char0n commented Feb 28, 2024

AsyncAPI 2.x addressed in #3872

char0n added a commit that referenced this issue Feb 28, 2024
@char0n
fix(reference): add support for external cycles detection
f83978f 
Refs #3863
@char0n char0n mentioned this issue Feb 28, 2024
Merged
@char0n
Copy link
Member Author

char0n commented Feb 28, 2024

OpenAPI 3.1.0 addressed in #3873

@char0n char0n closed this as completed Feb 28, 2024
char0n added a commit that referenced this issue Feb 28, 2024
@char0n
fix(reference): add support for external cycles detection in OpenAPI …
9cd15ff 
…3.1.0 dereference strategy (#3873)

Refs #3863
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

Labels
ApiDOM bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@char0n