Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apidom-converter: create unified error boundary interface #3998

Closed
char0n opened this issue Apr 3, 2024 · 1 comment
Closed

apidom-converter: create unified error boundary interface #3998

char0n opened this issue Apr 3, 2024 · 1 comment
Assignees
@char0n
Labels
ApiDOM converter

Comments

@char0n
Copy link
Member

char0n commented Apr 3, 2024

When conversion fails we need to return unified expected ConvertError. Currently we're returning original error.
@char0n char0n self-assigned this Apr 3, 2024
char0n added a commit that referenced this issue Apr 3, 2024
@char0n
feat(converter): create unified error boundary interface
45249de 
convert and convertApiDOM functions with now always return
ConverError instances on failure.

Refs #3998
@char0n char0n mentioned this issue Apr 3, 2024
Merged
@char0n
Copy link
Member Author

char0n commented Apr 3, 2024

Addressed in https://github.com/swagger-api/apidom/pull/3999/files

@char0n char0n closed this as completed Apr 3, 2024
char0n added a commit that referenced this issue Apr 3, 2024
@char0n
feat(converter): create unified error boundary interface (#3999)
833a918 
convert and convertApiDOM functions with now always return
ConverError instances on failure.

Refs #3998
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

Labels
ApiDOM converter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@char0n