Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apidom-ast: sync version of visit should throw if the returned value from the visitor is a promise #4007

Closed
char0n opened this issue Apr 4, 2024 · 1 comment
Closed

apidom-ast: sync version of visit should throw if the returned value from the visitor is a promise #4007

char0n opened this issue Apr 4, 2024 · 1 comment
Assignees
@char0n
Labels
ApiDOM enhancement New feature or request

Comments

@char0n
Copy link
Member

char0n commented Apr 4, 2024

This will effectively detect all the issues related to cases when async visitors are used with sync visit mechanism. All the higher level tooling will be able to benefit from this as well.
@char0n char0n added enhancement New feature or request ApiDOM labels Apr 4, 2024
@char0n char0n mentioned this issue Apr 4, 2024
Closed
char0n added a commit that referenced this issue Apr 4, 2024
@char0n
fix(ast): throw if visiting async visitor in sync mode
a198326 
Refs #4007
@char0n char0n mentioned this issue Apr 4, 2024
Merged
char0n added a commit that referenced this issue Apr 4, 2024
@char0n
fix(ast): throw while visiting async visitor in sync mode (#4009)
bd94545 
Refs #4007
@char0n
Copy link
Member Author

char0n commented Apr 4, 2024

Addressed in #4009

@char0n char0n closed this as completed Apr 4, 2024
@char0n char0n self-assigned this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

Labels
ApiDOM enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@char0n