Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for mutating node replacement in code traversal mechanism #4120

Closed
char0n opened this issue May 20, 2024 · 2 comments
Closed

Add support for mutating node replacement in code traversal mechanism #4120

char0n opened this issue May 20, 2024 · 2 comments
Assignees
@char0n
Labels
ApiDOM enhancement New feature or request

Comments

@char0n
Copy link
Member

char0n commented May 20, 2024 •
edited
Loading

We have native support only for immutable node replacement at this point. In certain situations (like in dereferencing) we want to perform mutable replacements. The goal of this issue is introduce simple API to perform mutable node replacements. We are not handling any complex parent replacements or requeue mechanism.

Ref swagger-api/swagger-js#3520
@char0n char0n self-assigned this May 20, 2024
@char0n char0n added enhancement New feature or request ApiDOM labels May 20, 2024
char0n added a commit that referenced this issue May 20, 2024
@char0n
feat(ast): add support for mutable node replacments (edits)
8fc0e0b 
Refs #4120
@char0n char0n mentioned this issue May 20, 2024
Merged
@char0n
Copy link
Member Author

char0n commented May 20, 2024

Addressed in #4121

@char0n char0n closed this as completed May 20, 2024
@char0n char0n mentioned this issue May 20, 2024
Closed
char0n added a commit that referenced this issue May 20, 2024
@char0n
feat(ast): add support for mutable node replacements (#4121)
b37ecd2 
Refs #4120
char0n added a commit that referenced this issue May 20, 2024
@char0n
fix(ast): fix visitor merging on mutable node replacements
a47c709 
Refs #4120
@char0n char0n mentioned this issue May 20, 2024
Merged
char0n added a commit that referenced this issue May 21, 2024
@char0n
fix(ast): fix visitor merging when performing node replacements (#4124)
c89cbad 
Refs #4120
@char0n
Copy link
Member Author

char0n commented May 21, 2024

Fix for visitor merging and mutable node replacement has been added in #4124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

Labels
ApiDOM enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@char0n