Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ls): fix completion paths, self and indirect refs #2975

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

frantuma
Copy link
Member

fixes completion of references:

  • doesn't include reference to self
  • fixes JSON Pointer paths escaping
  • doesn't include by default indirect references (target nodes being a reference themselves).
    Provides a completionContext option includeIndirectRefs: if set to true indirect refs are also included, but only when the document namespace (specification + version) allows for siblings of $ref field, as this is the only case where such a reference would make sense. Currently the only namespace supporting this is OpenAPI 3.1

@frantuma frantuma merged commit b275efa into main Jul 21, 2023
8 checks passed
@frantuma frantuma deleted the fix-ref-completion branch July 21, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant