Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate guava logic to java 8 #5

Closed
HugoMario opened this issue Feb 5, 2018 · 6 comments · Fixed by #7
Closed

Migrate guava logic to java 8 #5

HugoMario opened this issue Feb 5, 2018 · 6 comments · Fixed by #7

Comments

@HugoMario
Copy link
Contributor

There is an error with dependency classes from guava. But instead fixing it with maven dependency declaration, let's take this chance to migrate that logic to Java 8.

@jmini
Copy link
Contributor

jmini commented Feb 6, 2018

At the moment there is a compile dependency on Guava:

@HugoMario: I guess you mention rewritting the code for the second use case.


In the mean time I had a look a the dependencies tree, guava 15.0 is already a test scope dependency, so I added the same version a compile dependencies.

<dependency>
	<groupId>com.google.guava</groupId>
	<artifactId>guava</artifactId>
	<version>15.0</version>
</dependency>

@jmini jmini mentioned this issue Feb 6, 2018
@jmini
Copy link
Contributor

jmini commented Feb 6, 2018

I think the guava version included in the last released version of this project (1.0.0-rc0) was guava 23.0.

The guava dependency is no longer present in the last SNAPSHOT version used in the current dependencies.

See also my analysis (with screenshot) in #4.

@jmini
Copy link
Contributor

jmini commented Feb 6, 2018

I have missed usage of com.google.common.collect.LinkedListMultimap in JavaClientCodegen. Not sure what you want to do about it.

@HugoMario
Copy link
Contributor Author

Well, the idea is remove any guava dependency

@jmini
Copy link
Contributor

jmini commented Feb 6, 2018

To replace LinkedListMultimap with java8 code, I found this blog post: http://fahdshariff.blogspot.fr/2017/07/java-8-multimaps.html

Second pull request: #7.

@HugoMario
Copy link
Contributor Author

HugoMario commented Feb 6, 2018

Travis has a success build now, but it seems there is a config error.
https://api.travis-ci.org/v3/job/338265006/log.txt

I'll be finding out how to solve that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants