Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong feeder filenames in gatling tests #7616

Closed
atomfrede opened this issue Feb 8, 2018 · 2 comments · Fixed by #7635
Closed

Wrong feeder filenames in gatling tests #7616

atomfrede opened this issue Feb 8, 2018 · 2 comments · Fixed by #7635

Comments

@atomfrede
Copy link
Contributor

Description

Gatling language generates wrongly named bodyParams feeder file.
The generator generates e.g. xyz-BodyParams.csv while the generated gatling test expects xyz-bodyParams.csv which is also in line with other feeder files e.g. -headerParams.csv.

Swagger-codegen version

Latest master

Swagger declaration file content or url

Not relevant

Command line used for generation

...l scala-gatling...

Steps to reproduce

Use a yaml spec with body parameters and generate the gatling project.

Related issues/PRs

None found.

Suggest a fix/enhancement

Change

 FileUtils.writeStringToFile(new File(outputFolder + File.separator + dataFolder + File.separator + operation.getOperationId() + "-" + "BodyParams.csv"), StringUtils.join(bodyFeederParams, ","));

to

 FileUtils.writeStringToFile(new File(outputFolder + File.separator + dataFolder + File.separator + operation.getOperationId() + "-" + "bodyParams.csv"), StringUtils.join(bodyFeederParams, ","));

I can do a PR for that.

@atomfrede atomfrede changed the title Gatling Wrong feeder filenames in gatling tests Feb 8, 2018
@wing328
Copy link
Contributor

wing328 commented Feb 8, 2018

@atomfrede thanks for reporting the issue. Please file a PR so that we can review the fix more easily. Thanks!

@atomfrede
Copy link
Contributor Author

@wing328 I will make a PR during the weekend.

atomfrede added a commit to atomfrede/swagger-codegen that referenced this issue Feb 10, 2018
wing328 pushed a commit that referenced this issue Feb 12, 2018
* correct body params file name

close #7616

* update gradle gatling plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants