Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong generation of @JacksonXmlElementWrapper annotation #10333

Merged
merged 7 commits into from
Aug 31, 2020
Merged

Wrong generation of @JacksonXmlElementWrapper annotation #10333

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5d00b34
Wrong generation of @JacksonXmlElementWrapper annotation
sanjeevgiri Jun 19, 2020
358e5a4
Merge remote-tracking branch '9845/master' into 9845
sanjeevgiri Jun 19, 2020
93f4f00
Merge branch 'master' into 9845
sanjeevgiri Jun 19, 2020
588276b
Merge branch 'master' into 9845
sanjeevgiri Jun 24, 2020
5ff87d4
Merge branch 'master' into 9845
sanjeevgiri Aug 19, 2020
60a9ac3
Merge branch '9845' of https://github.com/colorcodecanvas/swagger-cod…
sanjeevgiri Aug 19, 2020
5ebcf75
ran ./bin/java-petstore-resttemplate-withxml.sh to highlight differen…
sanjeevgiri Aug 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/swagger-codegen/src/main/resources/Java/pojo.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ public class {{classname}} {{#parent}}extends {{{parent}}} {{/parent}}{{#parcela
{{#isContainer}}
{{#isXmlWrapped}}
// items.xmlName={{items.xmlName}}
@JacksonXmlElementWrapper(useWrapping = {{isXmlWrapped}}, {{#xmlNamespace}}namespace="{{xmlNamespace}}", {{/xmlNamespace}}localName = "{{#items.xmlName}}{{items.xmlName}}{{/items.xmlName}}{{^items.xmlName}}{{items.baseName}}{{/items.xmlName}}")
@JacksonXmlElementWrapper(useWrapping = {{isXmlWrapped}}, {{#xmlNamespace}}namespace="{{xmlNamespace}}", {{/xmlNamespace}}localName = "{{#xmlName}}{{xmlName}}{{/xmlName}}{{^xmlName}}{{baseName}}{{/xmlName}}")
Copy link
Contributor Author

@sanjeevgiri sanjeevgiri Jun 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JacksonXmlElementWrapper should use the swaggerArrayProperty.xml.name as its local name instead of swaggerArrayProperty.items.xml.name

In order to customize the name for the wrapped xml element, JacksonXmlProperty annotation also must be included.

@JacksonXmlProperty({{#isXmlAttribute}}isAttribute = true, {{/isXmlAttribute}}{{#xmlNamespace}}namespace="{{xmlNamespace}}", {{/xmlNamespace}}localName = "{{#items.xmlName}}{{items.xmlName}}{{/items.xmlName}}{{^items.xmlName}}{{baseName}}{{/items.xmlName}}")
{{/isXmlWrapped}}
{{/isContainer}}
{{/withXml}}
Expand Down