fix: use GENERATOR_HOST variable in server generation #11711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgreinacher
force-pushed
the
fix/generator-host-server
branch
from
fea35d2
to
7fbae43
Compare
fgreinacher
force-pushed
the
fix/generator-host-server
branch
from
7fbae43
to
2cca3c7
Compare
fgreinacher
force-pushed
the
fix/generator-host-server
branch
from
2cca3c7
to
4b8bc1f
Compare
Without this the spec won't render when the generator is exposed on a sub path
fgreinacher
force-pushed
the
fix/generator-host-server
branch
from
4b8bc1f
to
822bc32
Compare
|
Thanks! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
The changes in #3373 only made the variable work for client code generation. This PR adds the same logic to the server generation.
🛠 with ❤ at Siemens