Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use information in generator host for generating spec #11738

Merged
merged 4 commits into from Jun 2, 2022

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Mar 9, 2022

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

I missed that the current implementation does not consider base path and schemes in the GENERATOR_HOST variable correctly, making the generate spec incorrect for some scenarions.

🛠 with ❤ at Siemens

@fgreinacher
Copy link
Contributor Author

@frantuma This should probably be included in the next release :)

@fgreinacher
Copy link
Contributor Author

@frantuma Can I do something to get this in soonish? We're eagerly waiting for it 🙂

@fgreinacher
Copy link
Contributor Author

fgreinacher commented Apr 4, 2022

@HugoMario @frantuma Sorry folks to bug you, but it would be really great to have this reviewed/merged. We're a bit blocked by this at the moment. Also tell me if I can help somehow!

@fgreinacher
Copy link
Contributor Author

@HugoMario @frantuma Sorry folks to bug you, but it would be really great to have this reviewed/merged. We're a bit blocked by this at the moment. Also tell me if I can help somehow!

@HugoMario @frantuma New month, new try 😄 Do you see a chance to make progress here? As mentioned I'll gladly help you it with whatever needs to be done, just ping me ❤️

@fgreinacher
Copy link
Contributor Author

New month, new try 😄 Do you see a chance to make progress here? As mentioned I'll gladly help you it with whatever needs to be done, just ping me ❤️

@HugoMario @frantuma Here is your monthly ping 🙇

@HugoMario
Copy link
Contributor

lol
sorry @fgreinacher for delay. Let me check this and help you with the merge if everything is ok

@HugoMario HugoMario merged commit ab0793b into swagger-api:master Jun 2, 2022
@HugoMario
Copy link
Contributor

thanks a lot @fgreinacher
Sorry again for the delay to check this.

@fgreinacher fgreinacher deleted the fix/use-generator-host branch June 2, 2022 20:36
@fgreinacher
Copy link
Contributor Author

thanks a lot @fgreinacher
Sorry again for the delay to check this.

No worries and thanks for taking care ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants