New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use information in generator host for generating spec #11738
fix: use information in generator host for generating spec #11738
Conversation
@frantuma This should probably be included in the next release :) |
@frantuma Can I do something to get this in soonish? We're eagerly waiting for it 🙂 |
@HugoMario @frantuma Sorry folks to bug you, but it would be really great to have this reviewed/merged. We're a bit blocked by this at the moment. Also tell me if I can help somehow! |
@HugoMario @frantuma New month, new try 😄 Do you see a chance to make progress here? As mentioned I'll gladly help you it with whatever needs to be done, just ping me ❤️ |
@HugoMario @frantuma Here is your monthly ping 🙇 |
lol |
thanks a lot @fgreinacher |
No worries and thanks for taking care ✌️ |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.3.0.0
branch for changes related to OpenAPI spec 3.0. Default:master
.Description of the PR
I missed that the current implementation does not consider base path and schemes in the
GENERATOR_HOST
variable correctly, making the generate spec incorrect for some scenarions.🛠 with ❤ at Siemens