Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11852 fix override in typescript #11930

Merged

Conversation

viktorsml
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • [?] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Ticket: #11852

Just added the override keyword to template. This is needed because typescript throws error during compilation when not present.

@thekhegay
Copy link

@HugoMario please, check PR :)

@viktorsml
Copy link
Contributor Author

Workaround until resolved -> #11852 (comment)

@HugoMario HugoMario merged commit d802458 into swagger-api:master Oct 4, 2023
10 of 11 checks passed
@viktorsml viktorsml deleted the #11852-fix-override-in-typescript branch October 4, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants