Go fix enum numbers #12076
Merged
Go fix enum numbers #12076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bump maybe @HugoMario ? |
aethanol
commented
Aug 6, 2023
| @@ -486,13 +486,10 @@ public String toEnumVarName(String name, String datatype) { | |||
| if ("int".equals(datatype) || "int32".equals(datatype) || "int64".equals(datatype) | |||
| || "uint".equals(datatype) || "uint32".equals(datatype) || "uint64".equals(datatype) | |||
| || "float".equals(datatype) || "float32".equals(datatype) || "float64".equals(datatype)) { | |||
| String varName = name; | |||
There was a problem hiding this comment.
Golang identifiers can't be prefixed with _*. See fix generated output https://github.com/swagger-api/swagger-codegen/pull/12076/files#diff-e07213988c61a6f77400109f74d3bf2a72aab72499ee220bb02329be26e6e06aL17
|
thanks a lot @aethanol ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
fix #11615
Enum vars that start with numbers, but are typed as strings end up starting with a number which is invalid in golang.
Fixes regression introduced in 164d45f#diff-25213c27f6aedea540837be9a27725ec3a402e84b882164ee3f6595f9e2ffaa0L16
Enum consts must be unique across a package, this is solved by the enum name to be suffixed with the class name.
cc: @antihax @wing328 (you were listed as contributors to the go generators)