Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build swagger-codegen-cli-v3 with correct Dockerfile #12331

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

qhaas
Copy link

@qhaas qhaas commented Feb 5, 2024

closes #12321

PR checklist

  • [ X] Read the contribution guidelines.
  • [ NA] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [ X] Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • [ NA] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

As described in the comments of 12321, use the swagger-codegen-cli context / Dockerfile instead of swagger-generator/Dockerfile_minimal. I do not know of an easy way to test GitHub CI scripts like this, so I have not tested it, but this fix looks straightforward.

@tariqajyusuf
Copy link

@frantuma this is actively broken on the release script you ran a few days ago, can you please take a look at this?

@frantuma frantuma merged commit 0c2837e into swagger-api:3.0.0 Feb 19, 2024
4 checks passed
@tariqajyusuf
Copy link

Thanks @frantuma, can you kick off a run of the docker push to fix the live image? https://github.com/swagger-api/swagger-codegen/actions/workflows/docker-release-3.0.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants