-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript angular2 client #2645
Conversation
search: queryParameters | ||
}; | ||
{{#bodyParam}} | ||
requestOptions.body = JSOG.stringify({{paramName}}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vrolijkx seems like you have dropped the import JSOG
statement, did you forget to swap it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right will fix it in a moment.
@Vrolijkx Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR wont' count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors. Let me know if you need help fixing it. |
@wing328 Help for fixing the linking is always welcome. |
@Vrolijkx can you try the following? |
@wing328 Solved it by adding my work email to my account settings. |
@Vrolijkx now looks good to me. Can you also create |
@wing328 Added the samples. But noticed that when running the |
Yup, it's due to the recent restore of the original petstore spec. I would suggest you to create a new branch for your change moving forward. |
A working angular2 typescript client based up on @roni-frantchi https://github.com/sapienstech/typescript-angular2-swagger-codegen
With some small changes and added tests.
Will resolve #1809 also makes #2291 obsolete.