Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript angular2 client #2645

Merged
merged 9 commits into from
Apr 19, 2016
Merged

Typescript angular2 client #2645

merged 9 commits into from
Apr 19, 2016

Conversation

Vrolijkx
Copy link
Contributor

A working angular2 typescript client based up on @roni-frantchi https://github.com/sapienstech/typescript-angular2-swagger-codegen

With some small changes and added tests.

Will resolve #1809 also makes #2291 obsolete.

@Vrolijkx Vrolijkx mentioned this pull request Apr 19, 2016
search: queryParameters
};
{{#bodyParam}}
requestOptions.body = JSOG.stringify({{paramName}});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vrolijkx seems like you have dropped the import JSOG statement, did you forget to swap it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right will fix it in a moment.

@wing328
Copy link
Contributor

wing328 commented Apr 19, 2016

@Vrolijkx Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR wont' count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors.

Let me know if you need help fixing it.

@Vrolijkx
Copy link
Contributor Author

@wing328 Help for fixing the linking is always welcome.

@wing328
Copy link
Contributor

wing328 commented Apr 19, 2016

@Vrolijkx can you try the following?

https://help.github.com/articles/changing-author-info/

@Vrolijkx
Copy link
Contributor Author

@wing328 Solved it by adding my work email to my account settings.

@wing328
Copy link
Contributor

wing328 commented Apr 19, 2016

@Vrolijkx now looks good to me.

Can you also create ./bin/typescript-angular2-petstore.sh similar to ./bin/typescript-angular-petstore.sh and output the sample to samples/client/petstore/typescript-angular2? (remember to git add the new files)

@Vrolijkx
Copy link
Contributor Author

@wing328 Added the samples. But noticed that when running the all-petstore.sh script that a lot of samples are not up to date.

@wing328
Copy link
Contributor

wing328 commented Apr 19, 2016

Yup, it's due to the recent restore of the original petstore spec.

I would suggest you to create a new branch for your change moving forward.

@wing328 wing328 merged commit 25ccb25 into swagger-api:master Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

angular2 client
3 participants