add enums to Java Spring path, query, and header params

[thebignet]

Enums in header, query or path parameters where not generated as enums for Java Spring.

Inline enums are used for each api operation.

[cbornet]

Can you generate the samples ?

[thebignet]

Do you have a command for generating samples ? I don't think that it is documented

[cbornet]

bin/springboot-petstore-server.sh

[thebignet]

Samples stayed the same. In samples, enums in parameters are wrapped in lists. Changes so far only generate java enum if params are enums. Could use some help to make it work for enums wrapped in lists

[wing328]

@thebignet coincidentally I'm working on better enum support for list (or list of list) and map (or map of map). Stay tuned.

[wing328]

UPDATE: I've filed #3199 to support array/map (any dimensions) of enum (for C# in particular)

[wing328]

@thebignet about updating the Petstore sample or testing the change, please refer to https://github.com/swagger-api/swagger-codegen/blob/master/CONTRIBUTING.md#testing for more information.

[radik-sabirov]

About "files changed"...
I think that it's not good idea to add inner enum to api.mustache. It will work if you have only one path in your api class. In other words you will have the same enum in this api class after each path (endpoint).
Need to add one enum model and use it in api.mustache

[wing328]

@radik-sabirov I agree that defining the enum as model is better as it can be reused by different endpoints or model properties but that's up to the spec owner on how they define the enum (using enum model or inline)

[radik-sabirov]

@wing328
I've solved this issue and it works for me.
What I did:

model.mustache
added

{{#models}}
 {{#model}}{{#isEnum}}{{>modelEnum}}{{/isEnum}}{{^isEnum}}{{#description}}
...
{{/isEnum}}
  {{/model}}
{{/models}}

This template can create enum if it is enum...

created new modelEnum.mustache

 /**
 * {{^description}}{{{name}}}{{/description}}{{#description}}{{{description}}}{{/description}}
 */
 public enum {{#datatypeWithEnum}}{{.}}{{/datatypeWithEnum}}{{^datatypeWithEnum}}{{classname}}{{/datatypeWithEnum}} {
   {{#allowableValues}}{{.}}{{^-last}} , {{/-last}}{{#-last}};{{/-last}}{{/allowableValues}}
 }

About pathParams.mustache and queryParams.mustache
I've added this

...
@ApiParam(value = "{{{description}}}"{{#required}},required=true{{/required}}{{#allowableValues}}, allowableValues="{{#allowableValues}}{{#values}}{{.}}{{^-last}} , {{/-last}}{{#-last}}{{/-last}}{{/values}}{{/allowableValues}}"{{/allowableValues}} {{#defaultValue}}, defaultValue="{{{defaultValue}}}"{{/defaultValue}}) @PathVariable("{{paramName}}") {{#isEnum}}{{datatypeWithEnum}}{{/isEnum}}{{^isEnum}}{{{dataType}}}{{/isEnum}} {{paramName}}
...

service.mustache

...
ResponseEntity<{{>returnTypes}}> {{operationId}}({{#allParams}}{{#isEnum}}{{datatypeWithEnum}}{{/isEnum}}{{^isEnum}}{{{dataType}}}{{/isEnum}} {{paramName}}{{#hasMore}},
      {{/hasMore}}{{/allParams}});
{{/operation}}

[thebignet]

Can you make a PR for this ? I'd be interested in testing it.

[wing328]

@radik-sabirov may I know if you've cycle to submit a PR with the enhancement?

[TehBakker]

Any news on that?

[thebignet]

Closed for inactivity