Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to place environment files in the correct location #5168

Merged

Conversation

bluengreen
Copy link
Contributor

PR checklist

  • [ x ] Read the contribution guidelines.
  • [ x ] Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • [ x ] Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

This PR updates the environmentsFolder to place the environment files in the correct location within the config directory. Previously they were nested in config/config/. The correct location for rails is in config/environments.

@bluengreen bluengreen changed the title updated to place environment files in the correct location Update to place environment files in the correct location Mar 22, 2017
@wing328 wing328 added this to the v2.2.3 milestone Mar 23, 2017
@aegixx
Copy link

aegixx commented Apr 20, 2017

I probably don't count, but LGTM!

@wing328
Copy link
Contributor

wing328 commented Apr 24, 2017

@aegixx thanks for reviewing 👍

@wing328 wing328 merged commit 7282ad2 into swagger-api:master Apr 24, 2017
@wing328
Copy link
Contributor

wing328 commented Apr 24, 2017

@bluengreen thanks for the fix, which has been merged into master.

davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants