Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeScript][Node] Use TypeScript 2 typings system #6178

Merged
merged 2 commits into from
Jul 26, 2017
Merged

[TypeScript][Node] Use TypeScript 2 typings system #6178

merged 2 commits into from
Jul 26, 2017

Conversation

duanshiqiang
Copy link
Contributor

PR checklist

  • [x ] Read the contribution guidelines.
  • [x ] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [ x] Filed the PR against the correct branch: master for non-breaking changes and 3.0.0 branch for breaking (non-backward compatible) changes.

Description of the PR

resolves issue #6163
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

@wing328
Copy link
Contributor

wing328 commented Jul 26, 2017

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/swagger-api/swagger-codegen/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@duanshiqiang
Copy link
Contributor Author

@wing328 Thanks for reminding! I have modified the commits with correct email :)

@wing328
Copy link
Contributor

wing328 commented Jul 26, 2017

@duanshiqiang thanks for the PR, which looks good to me.

(tests passed via https://travis-ci.org/swagger-api/swagger-codegen/builds/257652049)

@wing328 wing328 merged commit f9eaef8 into swagger-api:master Jul 26, 2017
@wing328 wing328 added this to the v2.3.0 milestone Jul 26, 2017
@wing328 wing328 changed the title Ts node angular2 typings [TypeScript][Node] Use TypeScript 2 typings system Jul 27, 2017
@wing328
Copy link
Contributor

wing328 commented Aug 12, 2017

@duanshiqiang may I know if you've time to make the same enhancement to typescript-angular petstore client (samples/client/petstore/typescript-angular)?

Note: package.json is not automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants