Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #7906 [cpprest] add parameterToString for number type with unspecified format #7929

Merged
merged 1 commit into from Apr 2, 2018

Conversation

murzic4
Copy link
Contributor

@murzic4 murzic4 commented Mar 28, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Type number with unspecified format is generated to type double in C++ code.

 - name: some_number
          in: query
          type: number
          required: true

It doesnt have corresponding ApiClient::parameterToString method.
no test were updated

@ravinikam, @stkrwork, @fvarose, @etherealjoy, @MartinDelille could you please review my PR?

Comment

cpprest related scripts under ./bin/ were failed by some unknown reason before i have modified source code, sorry have no enougt time to fix them

@etherealjoy
Copy link
Contributor

etherealjoy commented Mar 29, 2018

@murzic4
The changes are OK. But you have to commit the changed cpprest samples [ApiClient.cpp, ApiClient.h ]

You need to run cmake with the correct CPPREST_ROOT variable
For example on my PC, I go to cpprest petstore folder and create directory build and go there, then
cmake .. -DCPPREST_ROOT=/usr/include/cpprest

Copy link
Contributor

@etherealjoy etherealjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please commit ApiClient.cpp, ApiClient.h after running the script?

@murzic4
Copy link
Contributor Author

murzic4 commented Mar 29, 2018

@etherealjoy, done

@wing328 wing328 merged commit bad1885 into swagger-api:master Apr 2, 2018
@wing328 wing328 added this to the v2.4.0 milestone Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants