New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spring] Fixes #5244 Include basePath @RequestMapping in Spring API template #8131
Conversation
When will a new version i.e. v2.2.4 release with this fix? |
@kerkhofsd is this going to be merged anytime soon? what is the workaround? maybe something like a |
@kerkhofsd i would really appreciate the merge of this. @RestController Is this PR for swagger 3.0 version ? currently still using 2.0. |
Should be nice if this were fixed! Doing the same now as @mikela10000 ... |
When will this PR will be merged? |
Ping |
As the creator of this PR (I'm just an open source contributor), I do not have any idea if this ever will be merged. |
Is it possible to close and reopen this PR? This step will bump one |
hi @kerkhofsd , sorry for this long and no fair delay. i'm going to check your changes and merge them. Thanks !! |
please build |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.3.0.0
branch for changes related to OpenAPI spec 3.0. Default:master
.@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)
Description of the PR
Add
@RequestMapping(value = "{{{contextPath}}}")
on class level in the api.mustache template to correctly support thebasePath
swagger parameter.To make this work for spring-cloud, I had to introduce a mustache variable
hostWithoutBasePath
and use this in the spring-cloudapiClient.mustache
template.