Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Getter/Setter naming convention not followed in generated models (#8282) #9129

Closed
wants to merge 4 commits into from
Closed

[Java] Getter/Setter naming convention not followed in generated models (#8282) #9129

wants to merge 4 commits into from

Conversation

karismann
Copy link

@karismann karismann commented Jan 28, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • (N/A) Copied the technical committee to review the pull request if your PR is targeting a particular programming language. -> nobody for Java

Description of the PR

[Java] Getter/Setter naming convention not followed in generated models #8282

fix the getter/setter when the second letter of the field name is already uppercase (following the JavaBeans API specification)

Details :
Override getterAndSetterCapitalize class in the JavaCodeGen class
Change Java test convert a model with a 2nd char upper-case property names and convert a model starting with two upper-case letter property names (getter and setter expected results)

useful links :

fix the getter/setter when the second letter of the field name is already uppercase (following the JavaBeans API specification)
@karismann karismann changed the title Issue 8282 java getter setter naming convention [Java] Getter/Setter naming convention not followed in generated models (#8282) Jan 28, 2019
@karismann karismann closed this Feb 8, 2019
@karismann karismann deleted the issue-8282_java-getter-setter-naming-convention branch February 8, 2019 17:21
@yanxch
Copy link

yanxch commented Feb 25, 2019

Hello @karismann,
is this not a problem anymore or why was this issue closed?

@karismann
Copy link
Author

hello @yanxch , fixed in the forked project : OpenAPITools/openapi-generator#2085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants