[JavaSpring] Fixed Issue 9250 - Codegen for file datatype #9490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atatype file in @ApiParam, @RequestParam, and set the required flags
CarloMendola
approved these changes
Nov 19, 2019
There was a problem hiding this comment.
i successfully tested this change and can be merged either to bump-snapshot and master branch.
This change allows codegen to work with multipart file upload with different names other than "file" and support required:false (see example below)
- in: formData
name: myFileName
type: file
required: false
description: My File object
This will translate in:
@ApiParam(value = "My File object") @Valid @RequestPart(value="myFileName", required=false) MultipartFile myFileName
Please consider merging this change asap.
Thanks,
Carlo
|
Hi @HugoMario and @frantuma, Small but actually valuable, to address the proper mapping of a multipart POST. TIA, |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated mustache file to populate correct code inside @ApiParam annotation and inside @RequestParam annotation, and added "required" attribute (true|false) inside @RequestParam Annotation.
This should fix #9250