Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State of CVE in current swagger-core v1.6.4 #4111

Closed
jehaineoracle opened this issue Feb 3, 2022 · 11 comments
Closed

State of CVE in current swagger-core v1.6.4 #4111

jehaineoracle opened this issue Feb 3, 2022 · 11 comments
Assignees

Comments

@jehaineoracle
Copy link

Anyone working on a patch for the CVE issues in swagger-core v1.6.4 ?

https://mvnrepository.com/artifact/io.swagger/swagger-core/1.6.4

@frantuma frantuma self-assigned this Feb 4, 2022
@frantuma
Copy link
Member

frantuma commented Feb 7, 2022

Addressed in #4114

@frantuma frantuma closed this as completed Feb 7, 2022
@jehaineoracle
Copy link
Author

@frantuma
Copy link
Member

frantuma commented Feb 7, 2022

@jehaineoracle can you clarify which vulnerability is not addressed?

@frantuma frantuma reopened this Feb 7, 2022
@jehaineoracle
Copy link
Author

@frantuma I believe the apache commons cve is addressed. But for the Guava CVE (https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-8908) there was a vulnerable api that has since been deprecated. For that vulnerability to clear do we have to wait for the deprecated api to be removed in a later version?

@frantuma
Copy link
Member

frantuma commented Feb 7, 2022

@jehaineoracle as the vulnerable API is not used throughout the project I'd say that we are not affected by it. Are you getting possibly a vulnerability report related to CVE-2020-8908 by some automated tool?

@jehaineoracle
Copy link
Author

@frantuma yes in 2.4.x of swagger-codegen https://github.com/swagger-api/swagger-codegen/tree/v2.4.25

@frantuma
Copy link
Member

frantuma commented Feb 7, 2022

@jehaineoracle swagger-codegen is a different project, we are addressing vulnerabilities of that project outside the scope of this ticket/repo. swagger-core 1.6.5 is not using any vulnerable deps/APIs. I would close this ticket if you don't have further comments

@jehaineoracle
Copy link
Author

Sorry I misspoke. swagger-core is a dependency for swagger-codegen. Our scan of swagger-codegen found swagger-core to have CVE's against it https://mvnrepository.com/artifact/io.swagger/swagger-core/1.6.4

@frantuma
Copy link
Member

frantuma commented Feb 7, 2022

@jehaineoracle right, as mentioned above we are addressing vulnerabilities of swagger codegen within that project, this will also mean updating swagger-core to 1.6.5.

@jehaineoracle
Copy link
Author

jehaineoracle commented Feb 7, 2022

@frantuma right. I'm just going to the root project flagged with the issue. Thanks..

I still see Guava as a dependency that hasn't eliminated its CVE, only deprecated the api with issue
Which is why I said that wasn't addressed yet.

@frantuma
Copy link
Member

frantuma commented Feb 7, 2022

As mentioned above guava CVE is not affecting swagger-core, as the vulnerable API is not used. We are closing this issue, if vulnerability alerts come up for 1.6.5 feel free to open a new one

@frantuma frantuma closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants