JaxrsApiReader misses some properties

[kongchen]

The reader: com.wordnik.swagger.jaxrs.JaxrsApiReader reads com.wordnik.swagger.annotations.ApiModelProperty to com.wordnik.swagger.model.ModelProperty, but the properties: notes and access are missing in ModelProperty

[MiguelGL]

I think I fixed this as of pull request #531

[fkirchhoff]

Is this fix planned to be part of the 1.3.8 release?

[fehguy]

Yes it is

[rajanramasamy]

Would it be possible to backport this bug fix to 1.3.7? Our release is coming up in one month and this bug is a showstopper.

[fehguy]

Hi, the problem is, these fields don't actually exist in the model property section of the swagger spec. So there's no place to put them in the output (the annotations shouldn't have them).

The spec is here:

https://github.com/reverb/swagger-spec/blob/master/versions/1.2.md#529-property-object

and as you see, those fields don't exist for models.

[kongchen]

Hi, will the annotations remove the unused fields in 1.3.8?

[fehguy]

Hi, we don't plan on removing them as they are not harming anything--we will make sure they're properly documented. @kongchen are you in the swagger 2.0 workgroup?

[kongchen]

Yes, I'm there.
2014-9-3 上午10:57于 "Tony Tam" notifications@github.com写道：

Hi, we don't plan on removing them as they are not harming anything--we
will make sure they're properly documented. @kongchen
https://github.com/kongchen are you in the swagger 2.0 workgroup?

—
Reply to this email directly or view it on GitHub
#508 (comment)
.

[webron]

@kongchen - To clarify, the javadocs were updated on version 1.3.7.

notes is indeed not in use.
access is used for access control rather than documentation.

[kongchen]

Thanks!