Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifications to response declarations #955

Closed
webron opened this issue Apr 1, 2015 · 2 comments
Closed

Modifications to response declarations #955

webron opened this issue Apr 1, 2015 · 2 comments
Assignees
@lugaru1234
Labels
P2
Milestone
v1.5

Comments

@webron
Copy link
Contributor

webron commented Apr 1, 2015

Following changes are proposed:

  • Either deprecate response-related values from @ApiOperation or add a code() field to it to be able to set the HTTP status code (it's not always 200). Even if deprecated, the values will be read, it's just there to encourage people to move to @ApiResponse for successful responses as well.
  • Add responseContainer() to @ApiResponse.
@webron webron added the P2 label Apr 1, 2015
@webron webron added this to the v1.5 milestone Apr 1, 2015
@fehguy
Copy link
Contributor

fehguy commented Apr 2, 2015

I suggest the latter to maintain 1.3.x compatibility

lugaru1234 added a commit to lugaru1234/swagger-core that referenced this issue Apr 29, 2015
@lugaru1234
Support fo ApiOperation.code() and ApiResponse.responseContainer() ha…
127684e 
…s been added swagger-api#955
@lugaru1234 lugaru1234 mentioned this issue Apr 29, 2015
Merged
tgianos added a commit to Netflix/genie that referenced this issue May 4, 2015
@tgianos
[#88] [#117] Fixing the collections for swagger 2.0 spec not backward…
06b3fe6 
… compatible with swagger 1.0. Issues in swagger opened for some of these. swagger-api/swagger-core#976 swagger-api/swagger-core#955 swagger-api/swagger-core#954
@fehguy
Copy link
Contributor

fehguy commented May 5, 2015

fixed in #1017

@fehguy fehguy closed this as completed May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lugaru1234 lugaru1234

Labels
P2
Projects
None yet
Milestone
v1.5
Development

No branches or pull requests
3 participants
@webron @fehguy @lugaru1234