Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort methods to make api generations reproducible #3266

Closed
wants to merge 1 commit into from

Conversation

slavb18
Copy link

@slavb18 slavb18 commented Aug 7, 2019

No description provided.

@webron
Copy link
Contributor

webron commented Aug 7, 2019

There's actually a downside to this. When it comes to the spec, the order is meaningless. I can see why some people may want it ordered, but they don't necessarily want it alphabetically. We used to have a way to control ordering in the past, but since the order information was removed from the spec, we decided to take it out.

We appreciate the effort with the PR but are inclined to not merge it.

@slavb18
Copy link
Author

slavb18 commented Aug 8, 2019

downside of not ordering is that naming of operations is different
e.g. there is two methods with same name from different subresources

e.g. method "getData": resource.getData, resource.subresource.getData

one of them gets operation name "getData" second "getData_1",
and this depends on order of methods.

May be there should be configuration option to configure ordering of methods ?
like JVM, NAME_ASCENDING in Junit @FixMethodOrder annotation

@frantuma
Copy link
Member

frantuma commented Dec 3, 2020

A solution has been implemented in #3740, see PR comment for details and usage scenarios. Closing this ticket, any further issues in this area should be reported in a new or not closed ticket.

@frantuma frantuma closed this Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants