Encoding form parameters via RequestBody on Method Level #3644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminHetzjelli
changed the title
WesleyMatsonJelli
approved these changes
Jul 21, 2020
Allow encoding for form parameters via the RequestBody annotation on method level.
- Format according to style guide - Remove extra prints from IT debugging - Remove unused import that was added by accident - Add test for FormParam without being wrapped in @BeanParam - Reduce number of vars in test method.
- Change incomplete comment. I can't remember what it was supposed to be. - Move content var declaration into tighter scope.
|
@BenjaminHetzjelli thanks! this is replaced by #3696, see comment there and in original question |
|
Thanks so much! The solution you've implemented seems great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe addresses part of #3282
Definitely addresses #3643
Allow setting encoding for form parameters via the
@RequestBodyannotation on method level. It could be more natural for users to allow using@Parameteron each@FormParam, but this way introduced a lot less complication to the code, esp in handling the params correctly both wrapped into and unwrapped from an@BeanParam.I've also added a couple tests to make sure it is read properly.