Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for hidden field in JsonCreator #3698

Merged
merged 4 commits into from Nov 30, 2020
Merged

Add test for hidden field in JsonCreator #3698

merged 4 commits into from Nov 30, 2020

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Sep 10, 2020 •
edited

Refs #3697
Refs #3706

@joschi joschi marked this pull request as ready for review November 30, 2020 10:09
@joschi
Copy link
Contributor Author

joschi commented Nov 30, 2020

@frantuma The problem has been successfully resolved in #3706.

Do you want to merge this PR for increasing the test coverage or should we simply close it?

@joschi joschi changed the title Add failing test for hidden field in JsonCreator (#3697) Add test for hidden field in JsonCreator Nov 30, 2020
@frantuma frantuma merged commit 259eff8 into swagger-api:master Nov 30, 2020
@frantuma
Copy link
Member

@joschi thanks a lot! missed this..

@joschi joschi deleted the hidden-field-jsoncreator branch December 8, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joschi @frantuma