Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for XmlSchema annotation during model generation #4278

Merged
merged 6 commits into from Oct 24, 2022

Conversation

RCBiczok
Copy link
Contributor

@RCBiczok RCBiczok commented Oct 22, 2022

The goal of this PR is to enable Model resolver of swagger-core to extract the XML namespace from XmlRootElement if no namespace attribute has been set, but an XmlSchema annotation is present in the java package where the class annotated with XmlRootElement exists

I had to add these changes, as we utilize have a XSD schema file -> JAXB Generator -> OpenAPI Model generation flow.
Changing the annotation directly is unfortunately not an option for us, hence this PR.

Please let me know if there are further questions / requests.

@RCBiczok RCBiczok changed the title Add support for XmlType and XmlSchema annotation during model generation Add support for XmlSchema annotation during model generation Oct 22, 2022
@ponelat
Copy link
Member

ponelat commented Oct 24, 2022

@frantuma your thoughts on this PR?

@frantuma frantuma merged commit 4072cb0 into swagger-api:master Oct 24, 2022
@frantuma
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants