Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwaggerEditor@next: Integrate latest VSCode + Monaco Editor versions #4848

Closed
char0n opened this issue Mar 25, 2024 · 2 comments
Closed

SwaggerEditor@next: Integrate latest VSCode + Monaco Editor versions #4848

char0n opened this issue Mar 25, 2024 · 2 comments

Comments

@char0n
Copy link
Member

char0n commented Mar 25, 2024

The goal of this issue is to replace monaco-editor dep with @codingame/monaco-vscode-editor-api. I've tried the following combo, but I've bumped in to CodinGame/monaco-vscode-api#377. Everything else worked.

The goal of this issue is to find a version of @codingame/monaco-vscode-editor-api that doesn't suffer with the issue described above.

The only breaking change within our code is that we need to use ModesRegistry from the vscode package and not the monaco-editor package:

import { ModesRegistry } from 'vscode/vscode/vs/editor/common/languages/modesRegistry';

Affected version combo:

    "monaco-editor": "npm:@codingame/monaco-vscode-editor-api@=3.2.2",
    "vscode": "npm:@codingame/monaco-vscode-api@=3.2.2",
@char0n
Copy link
Member Author

char0n commented Mar 26, 2024

The get around the issue described above, imports-loader needed to be utilized, and import for process library is now fully scoped to json-schema-ref-parser@9.

When json-schema-ref-parser is used in its v11 version, we can remove the special scoping.

Refs swagger-api/swagger-editor-cra@7efdb99

@char0n
Copy link
Member Author

char0n commented Mar 26, 2024

Addressed in #4860

@char0n char0n closed this as completed Mar 26, 2024
swagger-bot pushed a commit that referenced this issue Mar 26, 2024
# [5.0.0-alpha.90](v5.0.0-alpha.89...v5.0.0-alpha.90) (2024-03-26)

### Features

* use VSCode API + Monaco Editor built from vscode@1.87.2 ([#4860](#4860)) ([5d21610](5d21610)), closes [#4848](#4848)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant