Fix isJSON() to recognize leading tabs and new line characters #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user pastes JSON into the editor, the editor prompts to convert it to YAML. This works if the JSON contains leading spaces:
```
{"foo": "bar"}
```
but does not currently work if the leading whitespace includes new line characters or tabs -- in this case JSON is pasted "as is".
```
{"foo": "bar"}
```
This PR improves the `isJSON()` function to recognize `\t`, `\r` and `\n` in the leading whitespace. Tabs and new lines are allowed in the leading whitespace according to [RFC 4627](https://tools.ietf.org/html/rfc4627) (section 2) and [ECMA-404](https://www.ecma-international.org/publications/files/ECMA-ST/ECMA-404.pdf) (section 4):
> Insignificant whitespace is allowed before or after any of the six structural characters.
>
> The whitespace characters are: character tabulation (U+0009), line feed (U+000A), carriage return (U+000D), and space (U+0020).
shockey
approved these changes
Jul 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user pastes JSON into the editor, the editor prompts to convert it to YAML. This works if the JSON contains leading spaces:
but does not currently work if the leading whitespace includes new line characters or tabs -- in this case JSON is pasted "as is".
This PR improves the
isJSON()function to recognize\t,\rand\nin the leading whitespace. Tabs and new lines are allowed in the leading whitespace according to RFC 4627 (section 2) and ECMA-404 (section 4):