Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move completionContext to APIDomContext #4280

Merged
merged 1 commit into from
Jul 17, 2023
Merged

feat: move completionContext to APIDomContext #4280

merged 1 commit into from
Jul 17, 2023

Conversation

frantuma
Copy link
Member

No description provided.

@frantuma frantuma requested a review from char0n July 17, 2023 12:31
@char0n
Copy link
Member

char0n commented Jul 17, 2023

Commit message suggestions:

feat(editor-monaco-language-apidom): move completionContext to APIDomContext

or

feat(monaco-language-apidom): move completionContext to APIDomContext

@char0n
Copy link
Member

char0n commented Jul 17, 2023

@frantuma is this related to swagger-api/apidom@9f92eaa or #4216 somehow?

If yes, then ApiDOM need to be updated as well to latest version manually and package-lock.json regenerated.

Can you also add at least basic documentation about swagger-api/apidom@9f92eaa in #4216? Thanks!

@frantuma
Copy link
Member Author

@frantuma is this related to swagger-api/apidom@9f92eaa or #4216 somehow?

If yes, then ApiDOM need to be updated as well to latest version manually and package-lock.json regenerated.

Can you also add at least basic documentation about swagger-api/apidom@9f92eaa in #4216? Thanks!

@char0n this is not really related to #4216, but for being spotted while working on that..

Not really in scope of this PR, ApiDOM deps update and comment/doc #4216 will be added after related PRs will be merged

char0n
char0n approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frantuma frantuma merged commit 8ca0d34 into next Jul 17, 2023
2 checks passed
@swagger-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.0-alpha.69 🎉

The release is available on:

Your semantic-release bot 📦🚀

@char0n char0n deleted the fix-completion-context branch August 3, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@char0n char0n char0n approved these changes

Assignees

@char0n char0n

@frantuma frantuma

Labels
released on @alpha swagger-editor@next type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frantuma @char0n @swagger-bot