fix(execute): align form data builder with query builder behavior for…

… OpenAPI 2.0 (#3437) Refs #3436
swagger-api · Mar 25, 2024 · 1f39b90 · 1f39b90
1 parent 0fb65af
commit 1f39b90
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/src/execute/swagger2/parameter-builders.js b/src/execute/swagger2/parameter-builders.js
@@ -24,13 +24,17 @@ function formDataBuilder({ req, value, parameter }) {
     value = '0';
   }
 
-  if (value || parameter.allowEmptyValue) {
+  if (value) {
     req.form = req.form || {};
     req.form[parameter.name] = {
-      value,
-      allowEmptyValue: parameter.allowEmptyValue,
       collectionFormat: parameter.collectionFormat,
+      value,
     };
+  } else if (parameter.allowEmptyValue && value !== undefined) {
+    req.form = req.form || {};
+    const paramName = parameter.name;
+    req.form[paramName] = req.form[paramName] || {};
+    req.form[paramName].allowEmptyValue = true;
   }
 }
 

diff --git a/test/execute/main.js b/test/execute/main.js
@@ -424,7 +424,7 @@ describe('execute', () => {
     });
 
     describe('formData', () => {
-      test('should add an empty query param if the value is empty and allowEmptyValue: true', () => {
+      test('should not add an empty query param if the value is empty and allowEmptyValue: true', () => {
         // Given
         const spec = {
           host: 'swagger.io',
@@ -449,7 +449,12 @@ describe('execute', () => {
         const req = buildRequest({ spec, operationId: 'deleteMe', parameters: {} });
 
         // Then
-        expect(req.body).toEqual('petId=');
+        expect(req).toEqual({
+          url: 'http://swagger.io/v1/one',
+          method: 'DELETE',
+          credentials: 'same-origin',
+          headers: {},
+        });
       });
 
       test('should support collectionFormat', () => {