Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

querystring is deprecated now, is there any plan to move away from url or to replace url #2736

Closed
Ashwini02-Ghaytad opened this issue Dec 27, 2022 · 3 comments · Fixed by #3137
Closed

querystring is deprecated now, is there any plan to move away from url or to replace url #2736

Ashwini02-Ghaytad opened this issue Dec 27, 2022 · 3 comments · Fixed by #3137
Assignees
@char0n
Labels
dependencies Pull requests that update a dependency file released type: enhancement version: 3.x

Comments

@Ashwini02-Ghaytad
Copy link

Ashwini02-Ghaytad commented Dec 27, 2022 •
edited
Loading

While analyzing a issue we observed that swagger-client is pulling url and url is pulling querystring and querystring is deprecated now, is there any plan to move away from querystring or to replace querystring.

└─┬ swagger-client@3.18.5
  └─┬ url@0.11.0
    └── querystring@0.2.0
@char0n
Copy link
Member

char0n commented Mar 6, 2023

Hi @Ashwini02-Ghaytad,

Yes there is, the overall goal is to use WHATWG URL Spec and move away from legacy url API.

@char0n char0n mentioned this issue Sep 12, 2023
Merged
@char0n char0n self-assigned this Sep 12, 2023
@char0n char0n added version: 3.x type: enhancement dependencies Pull requests that update a dependency file labels Sep 12, 2023
@char0n
Copy link
Member

char0n commented Sep 12, 2023

Closed by #3137

@char0n char0n closed this as completed Sep 12, 2023
char0n added a commit that referenced this issue Sep 12, 2023
@char0n
feat: replace node-fetch with undici (#3137)
bc7ca17 
swagger-client requires Node.js >=12.20.0 and uses different fetch 
implementation depending on Node.js version:

>=12.20.0 <16.8 - node-fetch@3
>=16.8 <18 - undici
>=18 - native Node.js fetch

Closes #1220
Closes #2736
Closes #2415
Closes #2381
Closes #2187
Closes #2291
swagger-bot pushed a commit that referenced this issue Sep 12, 2023
@semantic-release-bot
chore(release): cut the 3.21.0 release [skip ci]
1785b43 
# [3.21.0](v3.20.2...v3.21.0) (2023-09-12)

### Features

* replace node-fetch with undici ([#3137](#3137)) ([bc7ca17](bc7ca17)), closes [#1220](#1220) [#2736](#2736) [#2415](#2415) [#2381](#2381) [#2187](#2187) [#2291](#2291)
@swagger-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

Labels
dependencies Pull requests that update a dependency file released type: enhancement version: 3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: replace node-fetch with undici swagger-api/swagger-js
3 participants
@char0n @swagger-bot @Ashwini02-Ghaytad