Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

honors spec content-type for POST requests when no body. see https:/… #1052

Closed
wants to merge 3 commits into from

Conversation

kwv
Copy link

@kwv kwv commented May 12, 2017

@shockey shockey self-requested a review July 7, 2017 23:46
@shockey
Copy link
Contributor

shockey commented Jul 12, 2017

The code looks good to me, but based on the discussion in #1022, it's not clear to me if this a use case we're going to support (sending content-type for empty POSTs).

@webron, would appreciate your input here 😄

@marjan-georgiev
Copy link

This feature is the only thing preventing us from using this library in our application. It would be great if it got merged in.

@shockey shockey requested a review from webron July 14, 2017 03:07
@shockey
Copy link
Contributor

shockey commented Oct 11, 2017

@webron, bump

@webron
Copy link
Contributor

webron commented Oct 20, 2017

I'm not convinced this is the right solution, and will be closing the PR without merging. Merging this PR will cause, in some cases, completely invalid requests. If you take the application/json example, you're telling the API producer that you're sending it an application/json- making it try to parse an empty string as a JSON which is just not a valid JSON. I'd be happy to reconsider if someone shows concrete information as to why it should be allowed, but until then...

@webron webron closed this Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants