Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3376 - Keyword properties fix #1108

Merged
merged 1 commit into from
Jul 18, 2017
Merged

Fixes #3376 - Keyword properties fix #1108

merged 1 commit into from
Jul 18, 2017

Conversation

owenconti
Copy link
Contributor

@owenconti owenconti commented Jul 17, 2017 •
edited by shockey
Loading

Fixes swagger-api/swagger-ui#3376.

Check to make sure properties is the root (first) instance of properties before running plugins.

Added a test to ensure new functionality works.

@owenconti
Fixes #3376 - Check to make sure properties is the root (first) insta…
b00db53 
…nce of properties before running plugins
@owenconti owenconti requested a review from shockey July 17, 2017 00:55
@owenconti owenconti mentioned this pull request Jul 17, 2017
Closed
shockey
shockey approved these changes Jul 18, 2017
View reviewed changes
Copy link
Contributor

@shockey shockey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shockey shockey merged commit 570013f into swagger-api:master Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shockey shockey shockey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@owenconti @shockey