You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 14, 2022. It is now read-only.
I'm working on a patch to at least fix that for my usage, but want to get it fixed for good . Any suggestions on what approach is better? I would say swagger shouldn't deal with this headers and let the cors module, that works as a middleware handle this config.
Suggestions appreciated. :-)
The text was updated successfully, but these errors were encountered:
yes, you're right that it shouldn't rely on it's own headers. if you can update the sample with the cors package and send a PR, i'll see about merging it.
On line 74 of swagger.js (https://github.com/wordnik/swagger-node-express/blob/master/Common/node/swagger.js#L74) cors headers are overwritten, this way if you use nodejs cors (https://npmjs.org/package/cors) or express cors (https://npmjs.org/package/express-cors) the Acces-Control-Allow-xxx headers are all overwritten.
I'm working on a patch to at least fix that for my usage, but want to get it fixed for good . Any suggestions on what approach is better? I would say swagger shouldn't deal with this headers and let the cors module, that works as a middleware handle this config.
Suggestions appreciated. :-)
The text was updated successfully, but these errors were encountered: