Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter.allowReserved is always null #1108

Closed
chanjarster opened this issue May 28, 2019 · 1 comment
Closed

Parameter.allowReserved is always null #1108

chanjarster opened this issue May 28, 2019 · 1 comment

Comments

@chanjarster
Copy link

Version:

<dependency>
    <groupId>io.swagger.parser.v3</groupId>
    <artifactId>swagger-parser</artifactId>
    <version>2.0.12</version>
</dependency>

OAS:

openapi: "3.0.0"
info:
  version: 1.0.0
  title: Swagger petstore
  license:
    name: MIT
servers:
  - url: http://petstore.swagger.io/v1
paths:
  /pets:
    get:
      summary: List all pets
      operationId: listpets
      tags:
        - pets
      parameters:
        - name: limit
          in: query
          allowReserved: false
      responses:
        '200':
          description: A paged array of pets
OpenAPIV3Parser parser = new OpenAPIV3Parser();
ParseOptions parseOptions = new ParseOptions();
parseOptions.setResolve(true);
parseOptions.setResolveCombinators(true);
parseOptions.setResolveFully(true);
parseOptions.setFlatten(false);
SwaggerParseResult parseResult = parser.readContents(content, null, parseOptions);
System.out.println(parseResult.getOpenAPI());

Notice that Parameter.allowReserved field is null:

class OpenAPI {
    openapi: 3.0.0
    info: class Info {
        title: Swagger petstore
        description: null
        termsOfService: null
        contact: null
        license: class License {
            name: MIT
            url: null
        }
        version: 1.0.0
    }
    externalDocs: null
    servers: [class Server {
        url: http://petstore.swagger.io/v1
        description: null
        variables: null
    }]
    security: null
    tags: null
    paths: class Paths {
        {/pets=class PathItem {
            summary: null
            description: null
            get: class Operation {
                tags: [pets]
                summary: List all pets
                description: null
                externalDocs: null
                operationId: listpets
                parameters: [class QueryParameter {
                    class Parameter {
                        name: limit
                        in: null
                        description: null
                        required: false
                        deprecated: null
                        allowEmptyValue: null
                        style: form
                        explode: true
                        allowReserved: null
                        schema: null
                        examples: null
                        example: null
                        content: null
                        $ref: null
                    }
                    in: query
                }]
                requestBody: null
                responses: class ApiResponses {
                    {200=class ApiResponse {
                        description: A paged array of pets
                        headers: null
                        content: null
                        links: null
                        extensions: null
                        $ref: null
                    }}
                    extensions: null
                }
                callbacks: null
                deprecated: null
                security: null
                servers: null
            }
            put: null
            post: null
            delete: null
            options: null
            head: null
            patch: null
            trace: null
            servers: null
            parameters: null
            $ref: null
        }}
    }
    components: null
}
gracekarina added a commit that referenced this issue May 29, 2019
gracekarina added a commit that referenced this issue May 29, 2019
fix for Parameter.allowReserved is always null - issue #1108
@gracekarina
Copy link
Contributor

@chanjarster thanks for the spec!. This issue was fixed by PR #1110.
Please let us know if it keeps happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants