'File' type migration

[webron]

Following #1 - we should write a migrator that does two things if the type is 'File':

1. Change the consumes field of this operation to "multipart/form-data".
2. Change the paramType of the parameter to "form".

[fge]

Uhm, IIRC, consumes didn't exist at all in 1.1, did it?

[webron]

It's not a version migration, it's a general malformation. I want to be
able to be robust and deal with as many malformations as possible, as long
as they don't cause funky problems.

On Mon, Apr 28, 2014 at 4:18 PM, Francis Galiegue
notifications@github.comwrote:

Uhm, IIRC, consumes didn't exist at all in 1.1, did it?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-41556565
.

[fge]

Uhm, OK, does that make the consumes field mandatory in this case? Because this is currently not validated

[webron]

Depends on how you look at it. If the type is File, it has to exist with
that value, but it's more complicated than that. It can exist for the
resource itself (at the root of the API Declaration) and that's enough too
(it's inherited).

On Mon, Apr 28, 2014 at 4:27 PM, Francis Galiegue
notifications@github.comwrote:

Uhm, OK, does that make the consumes field mandatory in this case?
Because this is currently not validated

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-41557540
.

[fge]

OK, so, if in a 1.1 declaration I see:

{
    "dataType": "File",
    "paramType": "whatever"
}

then I have to migrate it to:

{
    "type": "File",
    "paramType": "form",
    "consumes": "multipart/form-data"
}

Is that correct?

[webron]

Yes.
And if in 1.2 you see something similar, you need to 'fix' it to the
correct structure.

On Mon, Apr 28, 2014 at 4:40 PM, Francis Galiegue
notifications@github.comwrote:

OK, so, if in a 1.1 declaration I see:

{
"dataType": "File",
"paramType": "whatever"}

then I have to migrate it to:

{
"type": "File",
"paramType": "form",
"consumes": "multipart/form-data"}

Is that correct?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-41558931
.

[fge]

OK, I have a (tested) fix. Waiting to confirm whether that is fixed for you as well.

[fge]

Still waiting for sample JSON for continuing work on the problem ;)

[webron]

Yup, will get around to it tomorrow.
On Apr 28, 2014 8:43 PM, "Francis Galiegue" notifications@github.com
wrote:

Still waiting for sample JSON for continuing work on the problem ;)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-41589491
.

[fehguy]

@webron can i close this?

[webron]

Sure.