Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parser dereferencing when pathItems are the same #1994

Merged
merged 11 commits into from
Nov 13, 2023

Conversation

gracekarina
Copy link
Contributor

No description provided.

@gracekarina gracekarina marked this pull request as ready for review October 31, 2023 21:07
@gracekarina gracekarina merged commit 6cbc377 into master Nov 13, 2023
6 checks passed
@gracekarina gracekarina deleted the parser-resolving-duplicated-path branch November 13, 2023 16:23
@ttrubinov
Copy link

@gracekarina This changes introduced a new bug, but didn't fix the bug you are mentioning (you fixed issues when $ref is in responses, but not when $ref in requestBody).
My suggestion is to rollback this PR, I think we can't just delete that lines

ttrubinov added a commit to ttrubinov/swagger-parser that referenced this pull request Jan 15, 2024
…esolving-duplicated-path"

This reverts commit 6cbc377, reversing
changes made to c690d8d.

Reverting to fix a new bug
@gracekarina gracekarina self-assigned this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants