Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1886 #2064

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Issue 1886 #2064

merged 3 commits into from
Mar 21, 2024

Conversation

walaniam
Copy link
Contributor

@walaniam walaniam commented Mar 6, 2024

This PR is to fix #1886

When parsing openapi definitions the results are different on Linux and Windows systems. It has been documented with the test: OpenAPIV3ParserTest#testIssue1886.

On Linux OS the schemas (with and without the fix) are resolved to:
ArrayPojo, Enum1, Enum1_1, Enum2, Enum3, MapPojo, SetPojo, SimplePojo, TransactionsPatchRequestBody, additional-properties, array-pojo, locale-translation-item, map-pojo, set-pojo, simple-pojo, translation-item

On Windows OS, without this fix, schemas are resolved to following names:
ArrayPojo, Enum1, Enum2, Enum3, MapPojo, SetPojo, SimplePojo, TransactionsPatchRequestBody, schemas\array-pojo, schemas\enum1, schemas\map-pojo, schemas\set-pojo, schemas\simple-pojo

@walaniam
Copy link
Contributor Author

walaniam commented Mar 6, 2024

@gracekarina could you review it?

@gracekarina gracekarina merged commit e3746af into swagger-api:master Mar 21, 2024
6 checks passed
@gracekarina gracekarina self-assigned this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relative $refs fail on Windows due to potential issue in ExternalRefProcessor#processRefToExternalSchema
2 participants