fixing security requeriments

[gracekarina]

This PR fixes issue #562

[vinscom]

• As minimum JDK 1.8 is required. We should be utilising 1.8 features (Like stream) more while refactoring code.
• Test data should reflect as much as possible real world example.

[vinscom]

I think original code is fine except it is not loading scope. Whole function refactoring is not required.
For example:

JsonNode value = node.get(key);
if (key != null && JsonNodeType.ARRAY.equals(value.getNodeType())) {
    ArrayNode arrayNode = (ArrayNode)value;
    List<String> scopes = Stream
            .generate(arrayNode.elements()::next)
            .map((n) -> n.asText())
            .limit(arrayNode.size())
            .collect(Collectors.toList());
    securityRequirement.addList(key,scopes);
    if (securityRequirement.size() > 0){
        securityRequirements.add(securityRequirement);
    }
}

[gracekarina]

The original code was not loading the content of the security array.

[gracekarina]

Ok. I see your point. thanks!

[vinscom]

As scope is used for access control of API. Above scope is not good example of "scope".
You can take sample value from original Open API 3 spec.
For example:

openId_auth:
- write:pets
- read:pets

or

openId_auth:
- write
- read

[gracekarina]

I also added a test following this advice. Thanks!

[vinscom]

Great, just one last question. Why not updated "https://scopes.example.com/myScope" to reflect real world scope example. :)

[gracekarina]

that's actually a real world example jeje. from this ticket #562 :)

[vinscom]

Everything looks good to me.