Supporting change in additionalProperties Boolean and Schema #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralphdoe
reviewed
Dec 28, 2017
| ArraySchema model = new ArraySchema(); | ||
| model.setDescription(description); | ||
| model.setExample(example); | ||
| model.setItems(object.getAdditionalProperties()); | ||
| if (object.getAdditionalProperties() != null && object.getAdditionalProperties() instanceof Schema) { | ||
| items = (Schema) object.getAdditionalProperties(); |
There was a problem hiding this comment.
It seems the variable item was created only for assignation, if there's no validation or another use it might be a good idea to delete it and set directly model.setItems((Schema)object.getAdditionalProperties());
ralphdoe
suggested changes
Dec 30, 2017
|
This PR depends on swagger-api/swagger-core#2598 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs swagger-api/swagger-core#2461
#499 and fixing refs in additionalProperties Resolving RefExternalResolver #342 (in v3)