fixing classpath Issue #700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jul 18, 2018
| @@ -77,7 +76,7 @@ public static String readExternalUrlRef(String file, RefFormat refFormat, List<A | |||
| //its assumed to be a relative ref | |||
| String url = buildUrl(rootPath, file); | |||
|
|
|||
| return readExternalRef(url, RefFormat.URL, auths, null); | |||
| return readExternalRef(url, RefFormat.URL, auths, null,null); | |||
There was a problem hiding this comment.
The diff here is the space being removed. Please correct this formatting.
ghost
reviewed
Jul 18, 2018
| @@ -20,6 +48,9 @@ public static String loadFileFromClasspath(String location) { | |||
| inputStream = ClassLoader.getSystemResourceAsStream(location); | |||
| } | |||
|
|
|||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Are those extra empty lines really necessary?
ghost
reviewed
Jul 18, 2018
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Are those extra empty lines really necessary?
ghost
reviewed
Jul 18, 2018
| } | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Are those extra empty lines really necessary?
ghost
reviewed
Jul 18, 2018
| fail("Should have thrown an exception"); | ||
| } catch (RuntimeException e) { | ||
|
|
||
| } | ||
| } | ||
|
|
||
| @Test | ||
| /*@Test |
There was a problem hiding this comment.
If this test is no longer relevant, remove it; otherwise, uncomment and fix it.
There was a problem hiding this comment.
Thanks! I'll review and make the changes. This a work in progress
There was a problem hiding this comment.
OK. Since the PR is open, I assumed it was a final proposition. Keep up the good work 😊
|
replaced by #1134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue of classpath in parser #682.