Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare release 2.0.3 #829

Merged
merged 2 commits into from
Sep 5, 2018
Merged

prepare release 2.0.3 #829

merged 2 commits into from
Sep 5, 2018

Conversation

gracekarina
Copy link
Contributor

No description provided.

@frantuma
Copy link
Member

frantuma commented Sep 5, 2018

please build

1 similar comment
@frantuma
Copy link
Member

frantuma commented Sep 5, 2018

please build

@frantuma frantuma merged commit 270227f into 2.0 Sep 5, 2018
@@ -253,7 +253,7 @@
<swagger-parser-v2-version>1.0.38-SNAPSHOT</swagger-parser-v2-version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a snapshot in the dependencies is not a good idea in my opinion. Release should only have released versions in their dependencies.

Otherwise, builds can break (if the SNAPSHOT version is remove or if it evolves to something that is no longer compatible)

@jmini
Copy link
Contributor

jmini commented Sep 5, 2018

I fear that the released version 2.0.3 having a SNAPSHOT version in its dependency will not match requirements in downstream projects.

Any chance you can do something about it?

@frantuma
Copy link
Member

frantuma commented Sep 5, 2018

@jmini Thanks for spotting this! just released 2.0.4 correcting the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants